Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BoTN + BT interaction #2243

Merged
merged 2 commits into from
Dec 30, 2022
Merged

fix BoTN + BT interaction #2243

merged 2 commits into from
Dec 30, 2022

Conversation

lime-green
Copy link
Contributor

@lime-green lime-green commented Dec 29, 2022

When we have a blood-tapped death rune and use pestilence or blood strike with that rune then we shouldn't convert the rune used to a normal death rune, instead the other blood rune should be converted to death.

Also fixes btslot initialization (should be -1, previously was 0)

I uploaded the following video for proof: https://www.youtube.com/watch?v=E397itkbjQQ

  1. Blood Tap (1st rune is death, 2nd rune blood)
  2. Blood Boil (1st rune is death, 2nd rune blood on CD)
  3. Pestilence using 1st death rune (1st and 2nd runes are now death)

@jimmyt857 jimmyt857 merged commit 03521c9 into wowsims:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants